Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Adds packed support for all non-complex binary ops. #1534

Merged
merged 16 commits into from
Feb 5, 2019

Conversation

annxingyuan
Copy link
Collaborator

@annxingyuan annxingyuan commented Feb 4, 2019

Adds packed support for all non-complex binary ops.

PERF

This change is Reviewable

@annxingyuan annxingyuan self-assigned this Feb 5, 2019
@annxingyuan annxingyuan changed the title WIP: Pack all binary ops Adds packed support for all binary ops. Feb 5, 2019
@annxingyuan annxingyuan changed the title Adds packed support for all binary ops. Adds packed support for all non-complex binary ops. Feb 5, 2019
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @nsthorat)

@annxingyuan annxingyuan merged commit 9424e64 into master Feb 5, 2019
@annxingyuan annxingyuan deleted the pack_all_binary_ops branch February 5, 2019 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants