This repository was archived by the owner on Aug 15, 2019. It is now read-only.
For matMul gradient broadcasting logic must account for temporary reshaping of inputs. #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
src/ops/fused_test.ts, line 177 at r1 (raw file):
const grads = tf.grads((a, b, c) => { const prod = tf.matMul(a, b, false, false);
can you make these booleans named variables for readability? thx
…w/tfjs-core into fix_broadcasting_for_fuseds_op
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broadcasting logic in gradient computation for fused matMul.
This PR will fix test failures on tensorflow/tfjs-layers#397
This change is