This repository was archived by the owner on Aug 15, 2019. It is now read-only.
use precomputed tensor size #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedhtchang
force-pushed
the
use_precomputed_tensor_size
branch
from
5736936 to
54f7c60
Compare
dsmilkov
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Thank you!
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR resolves tensorflow/tfjs#873 and responds to @dsmilkov 's comment #1371 (review)
This change is