Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Ignore .yalc in .npmignore so we don't publish it. #1614

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Ignore .yalc in .npmignore so we don't publish it. #1614

merged 2 commits into from
Mar 8, 2019

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Mar 7, 2019

This change is Reviewable

@nsthorat nsthorat requested a review from dsmilkov March 7, 2019 22:47
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)


.npmignore, line 21 at r1 (raw file):

PULL_REQUEST_TEMPLATE.md
rollup.config.js
tsconfig.json

add yalc.lock as well. You will do it for all repos right? Also see tensorflow/tfjs#1344 (comment) Curious about your thoughts

Copy link
Contributor Author

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained


.npmignore, line 21 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

add yalc.lock as well. You will do it for all repos right? Also see tensorflow/tfjs#1344 (comment) Curious about your thoughts

Done. Agreed, we should do that for all repos and put a script in tfjs-core to do it. I'm gonna do this for all repos, core and union are the only ones that don't have it.

@nsthorat nsthorat merged commit 8b7efbf into master Mar 8, 2019
@nsthorat nsthorat deleted the ignore branch March 8, 2019 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants