Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Speedup build and CI testing #1624

Merged
merged 6 commits into from
Mar 15, 2019
Merged

Speedup build and CI testing #1624

merged 6 commits into from
Mar 15, 2019

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Mar 15, 2019

Speedup our travis CI build and testing by 2X.

This run took: 8 min 33 sec link
Yesterday's run took: 16min 53 sec link

Details

  • We used to re-compile our codebase 10 times over (every time you call ts-node and karma)
  • Now we compile it only once (yarn build) and run node and karma using the browserify plugin, which circumvents the typescript compilation
  • Also speedup the vscode build task by 1.5X by passing --noEmit to typescript to skip generating build artifacts.

This change is Reviewable

@dsmilkov dsmilkov changed the title WIP Speedup build Speedup build and CI testing Mar 15, 2019
@dsmilkov dsmilkov requested a review from nsthorat March 15, 2019 16:53
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)


package.json, line 54 at r2 (raw file):

    "coverage": "KARMA_COVERAGE=1 karma start --browsers='Chrome' --singleRun",
    "test": "karma start",
    "run-browserstack": "karma start --travis --reporters='dots,BrowserStack' --hostname='bs-local.com'",

should we put these all inside karma.conf.js just so they're not in 2 places?

Copy link
Contributor Author

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained


package.json, line 54 at r2 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

should we put these all inside karma.conf.js just so they're not in 2 places?

Done.

@dsmilkov dsmilkov merged commit 3136a3b into master Mar 15, 2019
@dsmilkov dsmilkov deleted the speed-build branch March 15, 2019 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants