-
Notifications
You must be signed in to change notification settings - Fork 945
Conversation
These are unit tests that run in the browser and serve as a quicker sanity check against api breakage wrt to core. Also add some documentation to cloudbuild.yml cc @annxingyuan I updated the cloudbuild.yml to make the webgpu tests not wait on yarn install of core (since it has its own yarn install). Let me know if you see any foresee any problem with this. |
CI seems to be failing on yarn test but it seems to be successful, any idea why? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov)
Hmm, failed after i synced with master. |
@nsthorat passing now, i think its just a slow test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @dsmilkov)
To see the logs from the Cloud Build CI, please join either
our discussion
or announcement mailing list.
This change is