Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Add react native unit tests to ci #1870

Merged
merged 11 commits into from
Aug 7, 2019
Merged

Add react native unit tests to ci #1870

merged 11 commits into from
Aug 7, 2019

Conversation

tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Aug 6, 2019

To see the logs from the Cloud Build CI, please join either
our discussion
or announcement mailing list.


This change is Reviewable

@tafsiri tafsiri changed the title add react native tests to ci WIP add react native tests to ci Aug 6, 2019
@tafsiri tafsiri changed the title WIP add react native tests to ci Add react native unit tests to ci Aug 7, 2019
@tafsiri tafsiri requested a review from dsmilkov August 7, 2019 15:08
@tafsiri
Copy link
Contributor Author

tafsiri commented Aug 7, 2019

These are unit tests that run in the browser and serve as a quicker sanity check against api breakage wrt to core.

Also add some documentation to cloudbuild.yml

cc @annxingyuan I updated the cloudbuild.yml to make the webgpu tests not wait on yarn install of core (since it has its own yarn install). Let me know if you see any foresee any problem with this.

@nsthorat
Copy link
Contributor

nsthorat commented Aug 7, 2019

CI seems to be failing on yarn test but it seems to be successful, any idea why?

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov)

@tafsiri
Copy link
Contributor Author

tafsiri commented Aug 7, 2019

Hmm, failed after i synced with master. Step #2 - "test": Chrome 76.0.3809 (Windows 10.0.0) gramSchmidt-non-tiny webgl2 {"WEBGL_CPU_FORWARD":false,"WEBGL_SIZE_UPLOAD_UNIFORM":0} 16x32 FAILED it failed with a timeout so maybe it was just slow to respond on that run? I'll kick the build again.

@tafsiri
Copy link
Contributor Author

tafsiri commented Aug 7, 2019

@nsthorat passing now, i think its just a slow test.

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @dsmilkov)

@dsmilkov dsmilkov merged commit 8a6d4d5 into master Aug 7, 2019
@dsmilkov dsmilkov deleted the add-rn-tests-to-ci branch August 7, 2019 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants