Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Add memory info to benchmarks page. #1875

Merged
merged 7 commits into from
Aug 12, 2019
Merged

Conversation

annxingyuan
Copy link
Collaborator

@annxingyuan annxingyuan commented Aug 12, 2019

Adds trendlines to track memory usage - they look like this:

Screen Shot 2019-08-12 at 9 29 59 AM

To see the logs from the Cloud Build CI, please join either
our discussion
or announcement mailing list.


This change is Reviewable

@annxingyuan annxingyuan self-assigned this Aug 12, 2019
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)


benchmarks/index.html, line 477 at r1 (raw file):

      }

      populateTrendline(document.querySelector("#perf-trendline-container"), times, true, printTime);

pull true and false to named constants

Copy link
Collaborator Author

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov)


benchmarks/index.html, line 477 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

pull true and false to named constants

Done

@nsthorat
Copy link
Contributor

Fixed the flaky test, you can update this branch and the tests should succeed.

@annxingyuan annxingyuan merged commit 6a94672 into master Aug 12, 2019
@annxingyuan annxingyuan deleted the add_mem_to_benchmarks branch August 12, 2019 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants