Skip to content

Conversation

@jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Aug 29, 2024

Changes:

  • Adds dataTestId prop
  • Sets data-testid on the shadow root div only (not containing my-map)

Screenshot from 2024-08-29 13-58-05

@netlify
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit 4e05af3
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/66d05ce795af5a0008f2b65a
😎 Deploy Preview https://deploy-preview-484--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jessicamcinchak jessicamcinchak requested review from a team and DafyddLlyr August 29, 2024 11:35
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant thank you 👍 Once part of a pre-release I'll re-test in planx-new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants