fix: drawGeojsonData should accept "Feature" and "FeatureCollection" data since introducing drawMany
#491
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RODO94
left a comment
RODO94
left a comment
There was a problem hiding this comment.
Looks good to me to switch from pulling in a feature to using a FeatureCollection like in geoJsonData prop.
Only had one question relating to adding a Feature or Features, mostly curious about the structuring of the code.
| let feature = new GeoJSON().readFeature(this.geojsonData, { | ||
| featureProjection: "EPSG:3857", | ||
| }); | ||
| geojsonSource.addFeature(feature); |
There was a problem hiding this comment.
Took me a second to realise the differences between these parts. Is the need for two different functions relate to one accessing the Features array of a FeatureCollection and the other just taking the Feature as an object, or is there another reason for having two different functions / if clauses?
There was a problem hiding this comment.
Yes exactly OpenLayers provides different methods depending if GeoJSON is single Feature or a FeatureCollection, and we want to keep our public-facing prop flexible to accepting eithe, therefore we do this conditional check !
Required to make drawing data "go back-able" in Planx when
drawManyis true.This was missed when introducing
drawManyprop -drawGeojsonDatawas only accepting/processing a single"Feature"and would fail if the passed in prop was a GeoJSON"FeatureCollection"- now account for either, same asgeojsonData