fix: output 4326 for lookup against planning.data.gov.uk API #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jessicamcinchak
approved these changes
Aug 8, 2025
Member
jessicamcinchak
left a comment
jessicamcinchak
left a comment
There was a problem hiding this comment.
Good catch! Once you merge this, happy to do another quick package release here (npm publishing permissions are limited, sorry!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
belatedly realizing we need to pass lat/lng to the next API here, so adding that to the output;
the BNG coordinates are still present in the output if those need to be used anywhere.