Skip to content

Conversation

@leifg
Copy link
Contributor

@leifg leifg commented Feb 14, 2025

There have been a couple of PRs that have been merged into master instead of main.

It looks like releases are built from main so all these changes did not make it into the release.

Ideally we add these changes and release a new version.

mmangino and others added 4 commits February 6, 2018 20:41
For thoughtbot#12. This would be helpful to confirm that we are getting a `nil` exit status. Thanks!
Insert an inspect on the exit status
Make sure we read stderr to not end up with a hang when the stderr buffer fills
@leifg leifg requested a review from cpytel as a code owner February 14, 2025 17:48
@leifg
Copy link
Contributor Author

leifg commented Feb 21, 2025

Additional context. I needed some changes to make CI pass:

Use latest version of JRruby (same minor, different patch)

Correctly implement stderr spec:

The BackticksRunner and PopenRunner doe not support outputs on stderr, therefore the spec that verifies whether large output on stderr hangs or not, doesn't make sense for these runners.

The only reason it works on MRI is because the way the spec is written, selects the ProcessRunner.

On JRuby the ProcessRunner is not supported, so it falls back to the BackticksRunner and then makes the spec fail.

@leifg leifg force-pushed the add-changes-from-master branch from 87e6f90 to c343bb7 Compare February 28, 2025 16:41
@leifg
Copy link
Contributor Author

leifg commented Mar 14, 2025

@cpytel is that something we can get released?

@nickcharlton
Copy link
Member

Thanks for opening this — I'm taking a look, and might break your PR out a bit in the process because it seems we've made a mess here.

@nickcharlton
Copy link
Member

I've taken everything here and broken it out into a set of different PRs:

There's a few other bits I'm noticing, so I'm going to check those first, but then I'll cut a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants