-
-
Notifications
You must be signed in to change notification settings - Fork 22
Add changes from master #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For thoughtbot#12. This would be helpful to confirm that we are getting a `nil` exit status. Thanks!
Insert an inspect on the exit status
Make sure we read stderr to not end up with a hang when the stderr buffer fills
|
Additional context. I needed some changes to make CI pass: Use latest version of JRruby (same minor, different patch) Correctly implement stderr spec: The The only reason it works on MRI is because the way the spec is written, selects the On JRuby the |
87e6f90 to
c343bb7
Compare
|
@cpytel is that something we can get released? |
|
Thanks for opening this — I'm taking a look, and might break your PR out a bit in the process because it seems we've made a mess here. |
|
I've taken everything here and broken it out into a set of different PRs:
There's a few other bits I'm noticing, so I'm going to check those first, but then I'll cut a new release. |
There have been a couple of PRs that have been merged into master instead of main.
It looks like releases are built from
mainso all these changes did not make it into the release.Ideally we add these changes and release a new version.