Made privacy policy link clickable #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
assigned
thunderbiscuit and
Prakhar-Agarwal-byte and unassigned
thunderbiscuit
thunderbiscuit
requested changes
Mar 3, 2023
Owner
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Nice work. 2 small comments and I think this is ready to merge.
- Would you mind adding a visual cue that the link is clickable? Either the text be maybe underlined with a blue/orange colour or maybe put inside a button with a small icon of link or something? Anything that indicates this is clickable would be fine I think.
- For Padawan, I've been trying to follow the conventional commits spec (not perfectly but somewhat). I use active verbs and capitalize the first letter of the commit message. So your commit messages in this case would be something like:
Feat: Made privacy policy link clickable
Fix: Update privacy policy link
Prakhar-Agarwal-byte
force-pushed
the
master
branch
from
1df19c3 to
0deba89
Compare
Prakhar-Agarwal-byte
force-pushed
the
master
branch
from
0deba89 to
1dd7a35
Compare
Contributor
Author
|
@thunderbiscuit Added an underline and changed color to orange to match with padawan theme. Also ammended the commit messages according to the spec. |
Owner
|
Perfect thanks! Just one little thing: I get notifications when people open issues or PRs on the repo, and when they comment. No need to tag me in all your messages 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
Screenshot: