Display amount in accepted standard #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Great stuff, thank you for the PR. For the btc denomination I'm looking at them and my favourite is the one where we use small spaces (I can't remember where I've seen this but it was in a related article). Something like this (from the Medium post you linked) but without the dots:
As for the satoshi version, I like how you have it as is. |
Owner
|
If you can rebase this I think it's ready to merge. |
thunderbiscuit
approved these changes
Mar 22, 2023
Owner
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
ACK. Thanks! This looks great. I'm not a fan of regex, but when it work it works. 🔥
Prakhar-Agarwal-byte
force-pushed
the
disp-amt
branch
from
e6f0d1b to
4bb6d64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257 Displays the amount as mentioned in https://medium.com/@mark.nugent.iv/grouping-bitcoins-fractional-digits-an-idea-whose-time-has-come-22d9dad8ac51
Screenshots: