Skip to content

first contribution and project setup #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thunderbiscuit merged 1 commit into from
Dec 6, 2023
Merged

first contribution and project setup #346

thunderbiscuit merged 1 commit into from
Dec 6, 2023

Conversation

@geigerzaehler242
Copy link
Contributor

@geigerzaehler242 geigerzaehler242 commented Dec 5, 2023 •
edited
Loading

Refactor: Update supported ios version and xcode version
Feat: Add BDK framework to project
Refactor: Add NoJDK target to be able to build without Gradle/JDK
UI: Add tab bar navigation
Feat: Add example/test use of BDK to display block height
UI: Add some temporary test buttons and test UI to the third tab

@thunderbiscuit
Copy link
Owner

thunderbiscuit commented Dec 6, 2023 •
edited
Loading

Hey great stuff!

I got it working locally. I don't want to slow down the first strides on this so I don't think it's necessary for this PR to be perfect before it gets merged. However here are a few things I think should get fixed before I merge:

1. My understanding is that the contents.xcworkspacedata file is mostly for user-specific local setup, and is similar to the .idea/ directory for Android. I don't really want to commit this to the repository right now, mostly because we're not a super big team with strong requirements to have identical local setups. You can remove this file from this PR.
2. Your commit message should follow the standard I've been using for Padawan so far, which is mostly based on conventional commits 1.0.0 (I'm not married to this exact spec, so I might decide to change the commit messages structure in the future, but I told myself I'd try to write the first 1000 commits using it and see how I feel about it afterwards). I also capitalize the tag and the message, so your message in this case could be something like Feat: Add first contribution to iOS app.
3. Would you mind renaming the iosApp/iosApp.xcodeproj/xcshareddata/xcschemes/iosApp copy.xcscheme to iosAppNoJDK.xcscheme? It took me some time to figure out how to fire both of those, and part of the problem was that in the UI the other build was called iosApp copy. Renaming the file fixes that.
4. There are a lot of views all in the same file and the viewmodel is doing a lot of work, and I assume this can be cleaned up in further PR, but if you want to separate those a little bit in this PR I'm ok with that too.

@geigerzaehler242 @thunderbiscuit
Feat: Add simple screens and viewmodel to iOS app
092be75 
- update supported ios version and xcode version
- add BDK framework to project
- add NoJDK target to be able to build without Gradle/JVK
- add tab bar navigation
- add example/test use of BDK to show block height
- add some test buttons and test UI to third tab
- Refactor: change target name from "iosApp copy" to iosAppNoJDK
thunderbiscuit
thunderbiscuit approved these changes Dec 6, 2023
View reviewed changes
Copy link
Owner

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 092be75. Thanks for the getting the ball rolling on this!

@thunderbiscuit thunderbiscuit merged commit 092be75 into thunderbiscuit:master Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees

@geigerzaehler242 geigerzaehler242

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geigerzaehler242 @thunderbiscuit