-
Notifications
You must be signed in to change notification settings - Fork 58
[iOS] Switch language with no restart #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Switch language with no restart #453
Conversation
28028da to
b27e334
Compare
|
Hi @Viniciuss-Moreira, I sent you some fixes you could take a look at. |
iOS/PadawanWallet/Features/More/Presentation/LanguangeTheme/LanguageManager.swift
Outdated
Show resolved
Hide resolved
iOS/PadawanWallet/Features/More/Presentation/MoreView/MoreView.swift
Outdated
Show resolved
Hide resolved
r1b2ns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the app, I realized that it’s working fine. These requested changes are just to keep the code cleaner.
1206b4b to
a1b9f84
Compare
|
Thanks @r1b2ns for the review! |
|
I gonna review it this weekend |
r1b2ns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job, man! In this PR, I just noticed some changes that aren’t related to your feature — for example, in LessonDetails. It would be great if you could implement the language override without changing those other parts.
Another thing is that you’re injecting the LanguageManager via @EnvironmentObject, but in some files, you’re still using the singleton. I think you can choose either approach, but not use both at the same time. Both are valid in my opinion — just not together.
Despite these comments, your code is very good. We’re just polishing it because this feature is very important and impacts the entire app.
iOS/PadawanWallet/Features/Lessons/Presentation/LessonDetail/LessonDetailView.swift
Show resolved
Hide resolved
iOS/PadawanWallet/Features/Lessons/Presentation/LessonDetail/LessonDetailView.swift
Outdated
Show resolved
Hide resolved
iOS/PadawanWallet/Features/Lessons/Presentation/LessonList/LessonsListView.swift
Show resolved
Hide resolved
iOS/PadawanWallet/Features/Lessons/Presentation/Model/LessonListModel.swift
Outdated
Show resolved
Hide resolved
iOS/PadawanWallet/Features/More/Presentation/LanguangeTheme/LanguageThemeScreen.swift
Outdated
Show resolved
Hide resolved
iOS/PadawanWallet/Features/More/Presentation/LanguangeTheme/LanguageThemeScreen.swift
Outdated
Show resolved
Hide resolved
iOS/PadawanWallet/Features/SendTransaction/SendTransactionViewModel.swift
Outdated
Show resolved
Hide resolved
iOS/PadawanWallet/Features/SendTransaction/SendTransactionViewModel.swift
Show resolved
Hide resolved
iOS/PadawanWallet/Features/SendTransaction/SendTransactionViewModel.swift
Show resolved
Hide resolved
a1b9f84 to
a078eeb
Compare
…component in App.
…tle" for "titleKey" in BottomSheetView and alterate all view models for this change.
a078eeb to
a220785
Compare
|
Thanks again man, for the review! the changes were very enlightening. I returned to the previous LessonListModel structure but converted the static strings to dynamic strings with the new struct I also returned to the original ForEach in If there’s anything else, I’ll be happy to see it. |
|
ACK a220785 |
thunderbiscuit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work guys!
ACK a220785.
Gravacao.de.Tela.2025-10-15.as.04.04.37.mov
Resume
This PR refers to issue #448 to make the user experience easier and more dynamic, without having to reopen the app for the language change to take effect.
Changes