Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Fixed issue #814 - [$100] Topcoder Member Profile: Redesign ratings graph #815

Merged
merged 18 commits into from
May 25, 2016
Merged

Fixed issue #814 - [$100] Topcoder Member Profile: Redesign ratings graph #815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7a75dd1
Fixed issue #814 - [$100] Topcoder Member Profile: Redesign ratings g…
smtryingcode May 20, 2016
2c3adca
Fixed lint issues
smtryingcode May 21, 2016
87f0674
Fixed unused var lint errors
smtryingcode May 21, 2016
8bc8b4b
Fixed review comments
smtryingcode May 22, 2016
80f1c47
Fixed lint errors
smtryingcode May 22, 2016
8799f4d
Removed extra semicolon
smtryingcode May 22, 2016
57f16f2
Fixed issues with tooltip
smtryingcode May 23, 2016
8803f42
Fixed lint errors
smtryingcode May 23, 2016
971d353
Fixed left lint errors
smtryingcode May 23, 2016
d5dc2d9
Fixed all review feedbacks
smtryingcode May 24, 2016
d82a31a
Fixed typos
smtryingcode May 24, 2016
5415f67
Implemented/Fixed review comments, except package.json. Will do that …
smtryingcode May 24, 2016
414474c
Fix indentation issue
smtryingcode May 24, 2016
c2331d4
Final fix - all review comments
smtryingcode May 24, 2016
4201416
updated package.json
smtryingcode May 24, 2016
6cd651a
Removed tabs
smtryingcode May 24, 2016
19eda22
Added code comments
smtryingcode May 24, 2016
00aea17
Fixed lint errors
smtryingcode May 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed lint errors
  • Loading branch information
@smtryingcode
smtryingcode committed May 24, 2016
commit 00aea179ea508801f86c38ba3cedd6f311906dbc
16 changes: 8 additions & 8 deletions app/directives/distribution-graph/distribution-graph.directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js

var mousemoveInterval = null

/* render react tooltip component */
/* render react tooltip component */
ReactDOM.unmountComponentAtNode(document.getElementById('chart-tooltip'))
ReactDOM.render(<Tooltip popMethod='click'>
<div className='tooltip-target'></div>
Expand All @@ -195,7 +195,7 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
</div>
</Tooltip>
, document.getElementById('chart-tooltip'))
$scope.isFocused = false
svg.selectAll('rect.hover')
.data(ranges)
Expand All @@ -218,8 +218,8 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
$scope.highlightedRating = d.start
$scope.displayCoders = true
$scope.numCoders = d.number
/* update tooltip location on mouseover, feature currently not inbuilt in react tooltip component */
/* update tooltip location on mouseover, feature currently not inbuilt in react tooltip component */
d3.select('#chart-tooltip')
.style('left', (d3.event.pageX-4) + 'px')
.style('top', (d3.event.pageY-4) + 'px')
Expand All @@ -240,12 +240,12 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
$scope.$digest()
})
.on('mousemove', function(d) {
/* update tooltip on mousemove, using interval of 50ms to improve performance */
window.clearTimeout(mousemoveInterval)
/* update tooltip on mousemove, using interval of 50ms to improve performance */
window.clearTimeout(mousemoveInterval)
var left = (d3.event.pageX-4)
var top = (d3.event.pageY-4)
mousemoveInterval = window.setTimeout(function(){
d3.select('#chart-tooltip')
.style('left', left + 'px')
Expand Down
8 changes: 4 additions & 4 deletions app/directives/history-graph/history-graph.directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
return y
}
}
/* render react tooltip component */
/* render react tooltip component */
ReactDOM.unmountComponentAtNode(document.getElementById('chart-tooltip'))
ReactDOM.render(<Tooltip popMethod='click'>
<div className='tooltip-target'></div>
Expand Down Expand Up @@ -283,8 +283,8 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
else
location.href = $filter('challengeLinks')({id: d.challengeId, 'track': $state.params.track, 'subTrack': $state.params.subTrack}, 'detail')
})
/* update tooltip location on mouseover, feature currently not inbuilt in react tooltip component */
/* update tooltip location on mouseover, feature currently not inbuilt in react tooltip component */
d3.select('#chart-tooltip')
.style('left', (d3.event.pageX-5) + 'px')
.style('top', (d3.event.pageY-5) + 'px')
Expand Down