Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Fix issue where MM scorer reviews were not having tests passed info i… #47

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Fix issue where MM scorer reviews were not having tests passed info i… #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/services/LeaderboardService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ async function getLeaderboard (challengeId, memberId) {
function getTestsPassed (metadata) {
const tests = metadata.tests || { total: 0, pending: 0, failed: 0 }

let testsPassed = tests.total - tests.pending - tests.failed
// MM scorer has passed tests count in the review already. Use it directly if it exists
let testsPassed = tests.passed ? tests.passed : (tests.total - tests.pending - tests.failed)

if (!testsPassed) {
testsPassed = 0
Expand Down