Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Fix issue where review summations are not being handled correctly #48

Merged
merged 1 commit into from
Nov 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix issue where review summations are not being handled correctly
  • Loading branch information
callmekatootie committed Nov 11, 2020
commit 5c270482a9888ebd3e108cee9163bf80c3ef027d
9 changes: 8 additions & 1 deletion src/models/Leaderboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,14 @@ const LeaderboardSchema = new Schema({
schema: [String]
},
status: { type: String },
finalDetails: { type: Object },
finalDetails: {
type: Object,
schema: {
aggregateScore: Number,
testsPassed: Number,
totalTestCases: Number
}
},
createdAt: {
type: String,
required: true
Expand Down
8 changes: 7 additions & 1 deletion src/services/LeaderboardService.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ async function updateLeaderboard (challengeId, memberId, review) {
let scoreLevelChanged = false

if (review.resource === 'reviewSummation') {
console.log('Updating leaderboard using review summation')
if (!review.aggregateScore) {
throw Error('Aggregate score is needed for the review summation')
}
_.assignIn(existRecords[0], {
finalDetails: {
aggregateScore: review.aggregateScore,
Expand All @@ -222,6 +226,7 @@ async function updateLeaderboard (challengeId, memberId, review) {
}
})
} else {
console.log('Updating leaderboard using review')
if (review.status !== 'queued') {
if (existRecords[0].aggregateScore > review.score) {
scoreLevel = 'down'
Expand Down Expand Up @@ -275,7 +280,8 @@ updateLeaderboard.schema = {
memberId: joi.string().required(),
review: joi.object().keys({
id: joi.string().required(),
score: joi.number().required().allow(null)
score: joi.number().allow(null),
aggregateScore: joi.number()
}).unknown(true).required()
}

Expand Down