This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Add metadata from review summation #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwdcwd
approved these changes
Nov 12, 2018
| function getTestsPassed (metadata = {}) { | ||
| const tests = metadata.tests || {} | ||
|
|
||
| let testsPassed = tests.total - tests.pending - tests.failed |
There was a problem hiding this comment.
won't this error when tests is just {} ?
| } | ||
| } | ||
| ) | ||
| } else { | ||
| logger.debug(`Record with ID # ${message.payload.id} does not exists in database. Creating the record`) | ||
| // const submission = await helper.reqToAPI(`${config.SUBMISSION_API_URL}/${message.payload.submissionId}`) | ||
|
|
||
| const challengeDetail = await helper.reqToAPI(`${config.CHALLENGE_API_URL}?filter=id=${submission.body.challengeId}`) | ||
|
|
||
| if (!helper.isGroupIdValid(challengeDetail.body.result.content[0].groupIds)) { |
There was a problem hiding this comment.
this too. Shouldn't we do this in a safer manner with _.get() with defaults?
cwdcwd
suggested changes
Nov 12, 2018
| @@ -10,7 +10,8 @@ const LeaderboardSchema = new Schema({ | |||
| challengeId: { type: String }, | |||
| memberId: { type: String }, | |||
| handle: { type: String }, | |||
| aggregateScore: { type: Number } | |||
| aggregateScore: { type: Number }, | |||
| testsPassed: { type: Number } | |||
There was a problem hiding this comment.
should we also post the total number of tests?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.