Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

PROD-1551 header -> dev #63

Merged
merged 7 commits into from
May 6, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
PROD-1551 #comment host config files in source control rather than in…
… S3;

add ADR-01 to describe the
decision #time 15m
  • Loading branch information
brooketopcoder committed May 6, 2022
commit 82a3a04ef6a9ab27edab8c8f8a065cd9a36ba5e7
8 changes: 4 additions & 4 deletions config/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ module.exports = Object.freeze({
APP_CONFIG: [
{
'appEnv': 'dev',
'mfeConfigPath': 'https://tc-public-static-files.topcoder-dev.com/micro-frontends/micro-frontends-config-development.json',
'mfeConfigPath': '/micro-frontends-config-development.json',
'mfeIndexPath': '/index.html',
'mfeRoutesPath': 'https://tc-public-static-files.topcoder-dev.com/micro-frontends/micro-frontends-routes-development.txt'
'mfeRoutesPath': '/micro-frontends-routes-development.txt'
},
{
'appEnv': 'prod',
'mfeConfigPath': 'https://tc-public-static-files.topcoder.com/micro-frontends/micro-frontends-config-production.json',
'mfeConfigPath': '/micro-frontends-config-production.json',
'mfeIndexPath': '/index.html',
'mfeRoutesPath': 'https://tc-public-static-files.topcoder.com/micro-frontends/micro-frontends-routes-production.txt'
'mfeRoutesPath': '/micro-frontends-routes-production.txt'
},
{
'appEnv': 'local-multi',
Expand Down
9 changes: 9 additions & 0 deletions config/docs/adr-01.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# ADR-01 2022-05-06

- by [email protected] and [email protected]

We moved the source of the config json and routes txt files to source control
from the S3 server in order to simplify modifications.

There is no sensitive info in these files, so there is no need to host
them any differently in prod or dev envs.