Allow user who created Job to edit it

[maxceem]

As a part of this issue #12 we have to allow editing jobs for users who have permissions for that.

At the moment we are only allowing editing jobs to the BookingManagers and Administrators, but we don't allow edit jobs to customer users who create such jobs.

The reason for this, because TaaS API uses V5 user ids to for createdBy and updatedBy fields:

{ // example job object
  title: "Job title",
  createdBy: "57646ff9-1cd3-4d3c-88ba-eb09a395366c", // <----- V5 User ID
  updatedBy: "077fd578-7463-457f-b6ef-22c02178d7f5"
  // other fields
}

But we don't know the V5 user id of the logged in user, we only know V3 userId and handle:

{
   userId: 40159127 // <----- V5 User ID
   handle: "pshah_manager"
}   

So we have to know somehow V5 User id of the logged-in user client-side. I'm not sure if we have such an endpoint that could be called by any user to obtain it.

FYI @nkumar-topcoder

[sandhiyakavi]

According to my observation, eventhough the creator of the job don't have Edit Job details button, he still be able to edit the job by accessing the Edit job page url.

[nkumar-topcoder]

@maxceem
Pls let me know if below approach helps.

1. get createdby userid from jobs api.
2. pass the UUID to v5/users. This will fetch userhandle.
   http://api.topcoder-dev.com/v5/users/f8eca99a-xxxxxxxxxxxxxxx
3. via userhandle we can call v3/users or v5/users and get related user info

And go-ahead for enhancement if it's fine.

additional info

https://api.topcoder-dev.com/v3/users?filter=handle=<userhandle>
https://api.topcoder-dev.com/v3/members/<userhandle>

http://api.topcoder-dev.com/v5/users?handle=<userhandle>

[maxceem]

@nkumar-topcoder we've created endpoint /taas-teams/me which returns the V5 user profile for the current user which we can use to implement this feature.

Sum up:

• We have withAuthentication HOC which takes care of user authentication and loads all the data related to user details and permissions. It wraps all the pages with authentication.

• withAuthentication HOC should additionally load V5 user profile. V5 user profile is returned by endpoint GET ${config.API.V5}/taas-teams/me.

  

  • make sure to correctly use Redux actions similar to how we load teamMembers
  • if an error happens then it should go to <LoadingIndicator error= then this error would appear like this https://monosnap.com/file/jTxdvBwknttmFTLIN7zI89eFdZeFg3

• Here is demo project which was created by pshah_customer https://platform.topcoder-dev.com/taas/myteams/17334. And in particular here is a job which was created by pshah_customer https://platform.topcoder-dev.com/taas/myteams/17334/positions/5b84a3bc-b759-4648-aa16-ff8232779501

• At the moment pshah_customer cannot see edit button even though he created this job, see screenshot https://monosnap.com/file/dLkddj5wkZgylc09r6QRaaY0nDbZ45

• So we should allow users to edit the job they created, so basically we have to add one more check here https://github.com/topcoder-platform/taas-app/blob/dev/src/routes/JobDetails/index.jsx#L109. If Job was created by the current user. Note, that job createdBy holds v5 user id, which we can get from Redux store now from authUser.v5UserProfile.id.

[maxceem]

@yoution would you like to handle it as a private task as per the comment above #112 (comment)?

Payment $50.

[yoution]

@maxceem please assign to me

[maxceem]

@yoution assigned

Branch to work: master. Create PR.

[maxceem]

@sandhiyakavi @SathyaJayabal this is fixed and ready for testing in DEV.

[sandhiyakavi]

Verified below cases in Dev. Working as expected.

1. Edit Job details button available and able to edit if member created Job from Taas app /Connect.
2. The permission level for the Booking Manager and Topcoder manager is correct.

bandicam.2021-05-19.12-42-35-807.mp4

[sandhiyakavi]

Verified in Prod.

Edit Job details button available and able to edit if member created Job from Taas app /Connect.

bandicam.2021-05-25.15-00-31-050.mp4