Skip to content

Search by skill IDs #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Search by skill IDs #706

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e6066ad
Initial skill search implementation
jmgasper Dec 21, 2023
19dcb22
Deploy branch to dev
jmgasper Dec 21, 2023
58a7a9b
Pin docker to older version, before version 7 that broke the builds
jmgasper Dec 21, 2023
52567b2
Debug logging
jmgasper Dec 21, 2023
9dc0953
Update to use boolQuery
jmgasper Dec 21, 2023
4d22cf0
Little more debug logging
jmgasper Dec 22, 2023
50f012e
Typo
jmgasper Dec 22, 2023
dc98303
Fix match_phrase usage
jmgasper Dec 22, 2023
c2283f0
Make sure the query is singular
jmgasper Dec 22, 2023
825b8c1
Typo
jmgasper Dec 22, 2023
adf6983
Remove debug logging
jmgasper Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Initial skill search implementation 
https://topcoder.atlassian.net/browse/TSJR-327
  • Loading branch information
@jmgasper
jmgasper committed Dec 21, 2023
commit e6066ad9f36e4d16b63c363d4569229875af0d1e
15 changes: 15 additions & 0 deletions src/services/ChallengeService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,20 @@ async function searchChallenges(currentUser, criteria) {
});
}

const includedSkillIds = _.isArray(criteria.skillIds) ? criteria.skillIds : [];

if (includedSkillIds.length > 0) {
for (const skillId of includedSkillIds) {
const matchPhrase = {};
matchPhrase[`skills.id`] = `${skillId}`;
mustQuery.push({
bool: {
should: matchPhrase,
},
});
}
}

// FIXME: Tech Debt
let excludeTasks = true;
// if you're an admin or m2m, security rules wont be applied
Expand Down Expand Up @@ -881,6 +895,7 @@ searchChallenges.schema = {
description: Joi.string(),
timelineTemplateId: Joi.string(), // Joi.optionalId(),
reviewType: Joi.string(),
skillIds: Joi.array().items(Joi.string()),
tag: Joi.string(),
tags: Joi.array().items(Joi.string()),
includeAllTags: Joi.boolean().default(true),
Expand Down