Skip to content

Change metal colors #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dara-K opened this issue Feb 7, 2018 · 4 comments
Closed

Change metal colors #773

Dara-K opened this issue Feb 7, 2018 · 4 comments
Assignees

Comments

@Dara-K
Copy link

Dara-K commented Feb 7, 2018

I added the new metal shades me and Vic chose, that is to
Winners.zip
to be used for medals and you can also see an updated color palette inside the archive.

@Dara-K
Copy link
Author

Dara-K commented Feb 7, 2018

Don't forget to read the notes on how they should be used.

@birdofpreyru
Copy link
Collaborator

@Dara-K
noticed that color levels in the image included into this archive disagree with what is defined in our code:

$tc-level-1: $tc-gray-50;
$tc-level-2: $tc-pastel-green;
$tc-level-3: $tc-pastel-blue;
$tc-level-4: $tc-pastel-yellow;
$tc-level-5: $tc-pastel-crimson;

The code definition looks correct to me, as we should start from a gray color.

@Dara-K
Copy link
Author

Dara-K commented Feb 8, 2018

Right. We forgot to add it in the design, please reuse same gray shade as before, those didn't change.

birdofpreyru added a commit to topcoder-archive/topcoder-platform-topcoder-react-ui-kit that referenced this issue Feb 9, 2018
@birdofpreyru
Copy link
Collaborator

birdofpreyru commented Feb 9, 2018

@Dara-K updated in dev (should be visible shortly at https://www.topcoder-dev.com/challenges)
There is one side-effect: now flag colors for 2-nd and places after 3-rd one are almost identical (those use $tc-gray-20, which is #a3a3ad. Also, the places after 3-rd used to have white text color, but now it looked a bit strange comparing to top places, where text became darker than the background, so I changed font color for low placement to $tc-gray-40. In result, flags for low placement look very similar to the 2-nd place one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants