Skip to content

Fix getChallengeRegistrants filter to not logged user #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: integration-v5-challenge-api
Choose a base branch
from
Open

Fix getChallengeRegistrants filter to not logged user #223

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b07363e
fix(members-service): fetch only active challenges
cagdas001 Aug 12, 2020
f4992bf
Merge pull request #220 from cagdas001/integration-v5-challenge-api
sushilshinde Aug 13, 2020
1f69bae
fix: for #4714
sushilshinde Aug 13, 2020
7cca2af
Fix challenge.track validation
luizrrodrigues Aug 14, 2020
c167da6
Merge pull request #222 from topcoder-platform/issue-4749
mtwomey Aug 14, 2020
12cf31e
Fix getChallengeRegistrants filter to not logged user
luizrrodrigues Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(members-service): fetch only active challenges 
At the `getUserResources` function, it will fetch only Active challenges.

Reference topcoder-platform/community-app#4714
  • Loading branch information
@cagdas001
cagdas001 committed Aug 12, 2020
commit b07363e003fd059c2a6af3d188439ae5c2e8aee0
8 changes: 5 additions & 3 deletions src/services/members.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
/* global XMLHttpRequest */
import _ from 'lodash';
import qs from 'qs';
import { decodeToken } from 'tc-accounts';
import logger from '../utils/logger';
import { getApiResponsePayload } from '../utils/tc';
import { getApi } from './api';
Expand Down Expand Up @@ -329,7 +330,8 @@ class MembersService {
* @param {Array} challengeId the challenge id
*/
async getChallengeResources(challengeId) {
const url = `/resources?challengeId=${challengeId}`;
const user = decodeToken(this.private.tokenV3);
const url = `/resources?challengeId=${challengeId}&memberId=${user.userId}`;
let res = null;

try {
Expand All @@ -346,14 +348,14 @@ class MembersService {
* @param {Array} memberId the member id
*/
async getUserResources(memberId) {
const url = `/resources/${memberId}/challenges`;
const url = `/challenges?status=Active&memberId=${memberId}`;
const res = await this.private.apiV5.get(url);
const challenges = await res.json();
const roles = await this.getResourceRoles();
const calls = [];

challenges.forEach(async (ch) => {
calls.push(this.getChallengeResources(ch));
calls.push(this.getChallengeResources(ch.id));
});

return Promise.all(calls).then((resources) => {
Expand Down