Skip to content

New Fix for Issue #2901 [MSFT-248] Unlabelled button #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: qa-accessibility
Choose a base branch
from
Open

New Fix for Issue #2901 [MSFT-248] Unlabelled button #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
MSFT 248 - Add aria-label to close modal dialog button.
  • Loading branch information
@gets0ul
gets0ul committed Jul 29, 2019
commit 40db19bf31986ee13387f7ec0b7e91d43398e029
1 change: 1 addition & 0 deletions src/shared/components/Modal/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ class Modal extends React.Component {
onClick={() => onCancel()}
className={theme.overlay}
type="button"
aria-label="Close Dialog"
/>
</React.Fragment>
),
Expand Down