"Given resources not found in config file" is incorrect error message

[jpmckinney]

Here:

cli/internal/txlib/delete.go

Line 103 in fc80657

color.Red("Given resources not found in config file.")

To reproduce:

$ tx delete --skip projectname.resourcename
# Initiating Delete

Deleting resource 'resourcename'
Resource 'resourcename' deleted

Then repeat (you can double-check that the .tx/config file hasn't changed):

$ tx delete --skip projectname.resourcename
# Initiating Delete

Given resources not found in config file.

The error message should be something like "Given resources not found in Transifex" instead, because the resource IS in the config file (local) – it's just not in Transifex (remote).

[rffontenelle]

It doesn't seem wrong if you consider that tx delete removes the resource from both config file and Transifex, and that tx uses the local config file to interact with the Transifex (hence it searches the config file for the resource and doesn't find it).

[jpmckinney]

cli/internal/txlib/delete.go

Lines 98 to 108 in fc80657

	err := deleteResource(&api, cfg, cfgResource, *arguments)
	if err != nil {
	if !arguments.Skip {
	return err
	} else {
	color.Red("Given resources not found in config file.")
	}
	} else {
	// Remove successful deletes from config
	cfg.RemoveResource(cfgResource)
	}

It tries to delete the resource on Transifex. If it can't, then whether or not the resource is described in the file it complains that "Given resources not found in config file."

If a user has a config file that contains the resource, and a Transifex project that doesn't contain the resource, they should see a different message that accurately describes the problem.

If you read the deleteResource function, you'll see that there are many other ways for the command to fail that have nothing to do with the config file.