Skip to content

Update angular demo README.md #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2019
Merged

Update angular demo README.md #61

merged 2 commits into from
May 9, 2019

Conversation

rynop
Copy link
Contributor

@rynop rynop commented May 9, 2019

No description provided.

RobertGardner
RobertGardner reviewed May 9, 2019
View reviewed changes
demo-angular/README.md Outdated
@@ -2,7 +2,7 @@

This Angular NativeScript app demos both [Standard and custom UI](https://stripe.com/docs/mobile/ios#standard-custom-components) Stripe components. Current forms of supported card input are Apple Pay (iOS only) and manual number entry.

**Note**: nativescript-stripe plugin currently is using the v13.2 Stripe SDK. Current Stripe SDK version is 15.0 is [in the works](https://github.com/triniwiz/nativescript-stripe/issues/51).
**Note**: `nativescript-dev-webpack` version `~0.22.0-next-2019-04-12-181144-02` is required
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "or later"

Might also add something about using npm i nativescript-dev-webpack@next.

I couldn't figure out when 0.22 is expected to release. Hopefully soon. We'll need to remember to remove this once it releases.

RobertGardner
RobertGardner reviewed May 9, 2019
View reviewed changes
Copy link
Collaborator

@RobertGardner RobertGardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't understand GitHub very well. Did you receive my comment on this or do I need to fire the Review Changes?

@rynop
Copy link
Contributor Author

rynop commented May 9, 2019

Yup got your comment, you did just fine. I've added the "or later". Don't want to tell folks to install nativescript-dev-webpack@next because lets say someone reads it a month from now, the stable version could be v0.22 and @next could be an un-stable/non backwards compatible version.

I'll keep an eye on nativescript-dev-webpack, how'd you know that 0.22.0-next-2019-04-12-181144-02 fixed your problem? Is there a related issue someplace? I'd be happy to write the author asking for an NPM release of v0.22.0 if there is something I can reference. Usually if you give a decent reason to ask for a version publish, OSS folks will oblige :)

@RobertGardner
Copy link
Collaborator

Good point about @next. I learned to use @next by following the nativescript-dev-webpack bug link you pointed out (NativeScript/nativescript-dev-webpack#843). :-) You could ping that bug and find out when it's going into a release, I guess.

@RobertGardner RobertGardner merged commit f46b2cf into triniwiz:master May 9, 2019
@rynop rynop deleted the patch-1 branch May 9, 2019 03:08
@rynop
Copy link
Contributor Author

rynop commented May 9, 2019

Haha yea - I have so much going on I forgot I ref'd that bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGardner RobertGardner RobertGardner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rynop @RobertGardner