Add the new build #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
requested review from
CoderHam and
deadeyegoodwin
and removed request for
CoderHam and
deadeyegoodwin
Member
Author
|
Sorry, I was trying to add two reviewers but it seems like I can add only one reviewer. |
deadeyegoodwin
requested review from
CoderHam and
deadeyegoodwin
and removed request for
CoderHam and
deadeyegoodwin
deadeyegoodwin
suggested changes
Sep 11, 2020
Contributor
deadeyegoodwin
left a comment
deadeyegoodwin
left a comment
There was a problem hiding this comment.
Put resources and protos in the src directory
| # PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | ||
| # PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | ||
| # OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
Contributor
There was a problem hiding this comment.
In general follow onnxruntime_backend as much as possible.
Member
Author
There was a problem hiding this comment.
@deadeyegoodwin Do you think I should add TRITON_PYTHONBACKEND_INCLUDE_PATHS TRITON_PYTHONBACKEND_LIB_PATHS to this backend too?
deadeyegoodwin
approved these changes
Sep 11, 2020
baojunliu
pushed a commit
to baojunliu/python_backend
that referenced
this pull request
Apr 22, 2022
* Initial implementation of backend * Update ReadMe * Correct library name to libtriton_pytorch.so * Add c10 and mkl to pytorch build * Fix ConvertDataTypeToTorchType function definition * Fix ModelConfigDataTypeToTorchType * Remove torch libs and deps from link interface * Add no-as-needed to include all torch libraries * shared -> unique ptr use reset instead of assigning new shared ptr * Fix segfault due to double SendErrorForResponses calls * Fix input buffer and tensor creation * review edits * Fix autofill to log error * cleanup * Use new BackendMemory API * review edits * Ensure post execution memory cleanup * Add torchvision op includes * Fix error response for invalid I/O name format * Fix naming convention of model config datatypes * Fix build to explicitly link in mkl deps to ensure symbol resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new python backend build now uses
FetchContent_Declarefor the installation of gRPC and other dependencies. Also, the build is now completely separated from the main repo tree.