Skip to content

fix: remove unused and error txid in trigger smart #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

waynercheung
Copy link
Contributor

What does this PR do?
remove unused and error txid in trigger smart contract

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

Codecov Report

Merging #2009 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2009      +/-   ##
=============================================
+ Coverage      44.75%   44.78%   +0.02%     
- Complexity      4029     4032       +3     
=============================================
  Files            489      489              
  Lines          28833    28832       -1     
  Branches        3007     3007              
=============================================
+ Hits           12905    12913       +8     
+ Misses         14775    14767       -8     
+ Partials        1153     1152       -1
Impacted Files Coverage Δ Complexity Δ
...ore/services/http/TriggerSmartContractServlet.java 4.65% <ø> (+0.1%) 2 <0> (ø) ⬇️
src/main/java/org/tron/core/net/node/NodeImpl.java 48.06% <0%> (-0.13%) 83% <0%> (-1%)
...org/tron/common/overlay/server/ChannelManager.java 67.56% <0%> (+1.35%) 20% <0%> (+1%) ⬆️
.../common/storage/leveldb/LevelDbDataSourceImpl.java 54.09% <0%> (+1.36%) 34% <0%> (ø) ⬇️
...n/java/org/tron/common/overlay/server/Channel.java 81.3% <0%> (+2.8%) 30% <0%> (+2%) ⬆️
.../main/java/org/tron/core/net/peer/TronHandler.java 100% <0%> (+15.38%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4797143...82d9918. Read the comment docs.

@renchenchang renchenchang merged commit ac50c5a into develop Feb 26, 2019
@shydesky shydesky deleted the hotfix/triggersmart_trxid branch November 13, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants