Skip to content

fix: get abi by address #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2019
Merged

fix: get abi by address #2018

merged 2 commits into from
Feb 28, 2019

Conversation

CodeNinjaEvan
Copy link
Contributor

@CodeNinjaEvan CodeNinjaEvan commented Feb 28, 2019

What does this PR do?
Fixed get abi when emit an event in construct.

Why are these changes required?
Events in contract's construct could not be query from deposit. so should get from Create function.

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

Codecov Report

Merging #2018 into develop will increase coverage by 0.36%.
The diff coverage is 37.17%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2018      +/-   ##
=============================================
+ Coverage      44.49%   44.86%   +0.36%     
- Complexity      4034     4219     +185     
=============================================
  Files            494      494              
  Lines          29030    30055    +1025     
  Branches        3020     3242     +222     
=============================================
+ Hits           12917    13483     +566     
- Misses         14960    15387     +427     
- Partials        1153     1185      +32
Impacted Files Coverage Δ Complexity Δ
...g/tron/common/runtime/vm/LogInfoTriggerParser.java 11.25% <0%> (-1.43%) 3 <0> (ø)
...main/java/org/tron/common/runtime/RuntimeImpl.java 62.87% <54.71%> (-0.61%) 54 <0> (ø)
...ron/core/services/http/FullNodeHttpApiService.java 2.83% <0%> (-0.55%) 2% <0%> (ø)
...in/java/org/tron/core/services/WitnessService.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
src/main/java/org/tron/core/db/KhaosDatabase.java 63.69% <0%> (+0.63%) 24% <0%> (+1%) ⬆️
...n/java/org/tron/common/overlay/server/Channel.java 79.43% <0%> (+0.93%) 29% <0%> (+1%) ⬆️
...ain/java/org/tron/core/services/RpcApiService.java 7.47% <0%> (+1.21%) 18% <0%> (+8%) ⬆️
...org/tron/common/overlay/server/ChannelManager.java 67.56% <0%> (+1.35%) 20% <0%> (+1%) ⬆️
...ay/discover/node/statistics/MessageStatistics.java 68.96% <0%> (+1.37%) 21% <0%> (ø) ⬇️
...a/org/tron/common/overlay/server/MessageQueue.java 84.78% <0%> (+2.17%) 33% <0%> (+1%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3899187...bfa6d74. Read the comment docs.

@CodeNinjaEvan CodeNinjaEvan merged commit d9a9ab0 into develop Feb 28, 2019
@shydesky shydesky deleted the Hotfix/internalEventParser branch November 13, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants