Skip to content

create2 new storage-key #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2019
Merged

Conversation

ithinker1991
Copy link
Contributor

@ithinker1991 ithinker1991 commented May 28, 2019

What does this PR do?

make sure create2 to same address with different storage

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@ithinker1991 ithinker1991 requested review from llwslc and tjchern May 28, 2019 12:37
@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #2259 into release_3.6 will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##             release_3.6   #2259      +/-   ##
================================================
+ Coverage          42.57%   42.6%   +0.03%     
+ Complexity          4457    4353     -104     
================================================
  Files                541     537       -4     
  Lines              32988   32554     -434     
  Branches            3646    3587      -59     
================================================
- Hits               14045   13870     -175     
+ Misses             17602   17361     -241     
+ Partials            1341    1323      -18
Impacted Files Coverage Δ Complexity Δ
...in/java/org/tron/core/capsule/ContractCapsule.java 83.33% <100%> (+0.47%) 15 <1> (+1) ⬆️
...va/org/tron/common/runtime/vm/program/Storage.java 78% <100%> (+5.5%) 13 <2> (+2) ⬆️
...main/java/org/tron/common/storage/DepositImpl.java 55.38% <100%> (+0.47%) 76 <0> (+1) ⬆️
...va/org/tron/common/runtime/vm/program/Program.java 50.87% <100%> (+0.24%) 138 <0> (+1) ⬆️
src/main/java/org/tron/core/db/Manager.java 44.06% <0%> (-3.43%) 116% <0%> (-106%)
...rg/tron/core/actuator/UnfreezeBalanceActuator.java 68.3% <0%> (-1.06%) 42% <0%> (+13%)
...ava/org/tron/core/db/accountstate/TrieService.java
.../accountstate/storetrie/AccountStateStoreTrie.java
...db/accountstate/callback/AccountStateCallBack.java
.../tron/core/db/accountstate/AccountStateEntity.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce7fe8...1b8cea5. Read the comment docs.

@CodeNinjaEvan CodeNinjaEvan merged commit 73d7536 into release_3.6 May 28, 2019
@shydesky shydesky deleted the hotfix/new_storage_create2 branch November 13, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants