Skip to content

create2 new storage-key #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2019
Merged

Conversation

ithinker1991
Copy link
Contributor

What does this PR do?

fix npe
create2 for new storage with trxHash

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@ithinker1991 ithinker1991 requested a review from BlueHoopor May 29, 2019 07:42
@ithinker1991 ithinker1991 force-pushed the hotfix/new_storage_create2_1 branch from f8f698e to 582ae21 Compare May 29, 2019 07:44
review code

revise code
@ithinker1991 ithinker1991 force-pushed the hotfix/new_storage_create2_1 branch from 582ae21 to b7b31fb Compare May 29, 2019 07:46
@codecov-io
Copy link

Codecov Report

Merging #2267 into release_3.6 will decrease coverage by 0.06%.
The diff coverage is 60%.

Impacted file tree graph

@@               Coverage Diff                @@
##             release_3.6   #2267      +/-   ##
================================================
- Coverage          42.56%   42.5%   -0.07%     
+ Complexity          4460    4338     -122     
================================================
  Files                541     537       -4     
  Lines              33022   32487     -535     
  Branches            3655    3561      -94     
================================================
- Hits               14057   13807     -250     
+ Misses             17615   17360     -255     
+ Partials            1350    1320      -30
Impacted Files Coverage Δ Complexity Δ
...va/org/tron/common/runtime/vm/program/Program.java 50.87% <ø> (ø) 138 <0> (ø) ⬇️
...main/java/org/tron/common/runtime/RuntimeImpl.java 60.77% <0%> (ø) 50 <1> (-1) ⬇️
...ain/java/org/tron/core/capsule/ReceiptCapsule.java 71.05% <0%> (ø) 22 <0> (-1) ⬇️
...main/java/org/tron/common/storage/DepositImpl.java 55.78% <100%> (+0.4%) 78 <0> (+2) ⬆️
...va/org/tron/common/runtime/vm/program/Storage.java 68.75% <50%> (-9.25%) 13 <1> (ø)
src/main/java/org/tron/core/db/Manager.java 44.06% <0%> (-3.43%) 116% <0%> (-106%)
...ava/org/tron/core/db/accountstate/TrieService.java
.../accountstate/storetrie/AccountStateStoreTrie.java
...db/accountstate/callback/AccountStateCallBack.java
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4f9f8...dfff2c7. Read the comment docs.

@BlueHoopor BlueHoopor merged commit a458075 into release_3.6 May 29, 2019
@shydesky shydesky deleted the hotfix/new_storage_create2_1 branch November 13, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants