Skip to content

Feature/add check contractResult stest #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 19, 2019

Conversation

MiraculousWang
Copy link
Contributor

What does this PR do?
add check contractResult stest and modify deploy.sh
Why are these changes required?
add check contractResult stest and modify deploy.sh
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

Codecov Report

Merging #2313 into develop will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2313      +/-   ##
=============================================
- Coverage      42.57%   42.42%   -0.16%     
+ Complexity      4362     4346      -16     
=============================================
  Files            538      538              
  Lines          32551    32551              
  Branches        3576     3576              
=============================================
- Hits           13859    13810      -49     
- Misses         17355    17417      +62     
+ Partials        1337     1324      -13
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/tron/core/db/PeersStore.java 17.24% <0%> (-17.25%) 2% <0%> (-2%)
...va/org/tron/common/overlay/discover/node/Node.java 50.84% <0%> (-11.87%) 12% <0%> (-3%)
...n/overlay/discover/node/statistics/Reputation.java 30.23% <0%> (-10.47%) 1% <0%> (-1%)
...tron/common/overlay/discover/node/NodeManager.java 44.02% <0%> (-8.18%) 22% <0%> (-2%)
...tron/common/overlay/discover/node/NodeHandler.java 45.96% <0%> (-6.46%) 17% <0%> (-3%)
...erlay/discover/node/statistics/NodeStatistics.java 38.09% <0%> (-4.77%) 4% <0%> (-3%)
...overlay/discover/node/statistics/MessageCount.java 52.77% <0%> (-2.78%) 6% <0%> (-1%)
src/main/java/org/tron/core/db/Manager.java 43.99% <0%> (-0.2%) 117% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45454c3...9c2acc4. Read the comment docs.

Copy link
Contributor

@wangzichichi wangzichichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiraculousWang MiraculousWang merged commit 8b5a2cb into develop Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants