Hotfix/split db config #2668
Merged
Hotfix/split db config #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2668 +/- ##
=============================================
- Coverage 30.81% 30.75% -0.06%
+ Complexity 1751 1744 -7
=============================================
Files 367 367
Lines 18256 18235 -21
Branches 2136 2135 -1
=============================================
- Hits 5625 5608 -17
+ Misses 11958 11956 -2
+ Partials 673 671 -2
Continue to review full report at Codecov.
|
shydesky
reviewed
Nov 25, 2019
| public static void initVMConfig(Args cfgArgs) { | ||
| VMConfig.setMaxTimeRatio(cfgArgs.getMaxTimeRatio()); | ||
| VMConfig.setMinTimeRatio(cfgArgs.getMinTimeRatio()); | ||
| VMConfig.setDebug(cfgArgs.isDebug()); |
There was a problem hiding this comment.
Whether isDebug should be in this VMConfig or not?
shydesky
reviewed
Nov 25, 2019
| VMConfig.setDebug(cfgArgs.isDebug()); | ||
| VMConfig.setCheckFrozenTime(cfgArgs.getCheckFrozenTime()); | ||
| VMConfig.setProposalExpireTime(cfgArgs.getProposalExpireTime()); | ||
| VMConfig.setSolidityNode(cfgArgs.isSolidityNode()); |
There was a problem hiding this comment.
Whether isSolidityNode should be in this VMConfig or not?
shydesky
reviewed
Nov 25, 2019
| VMConfig.setMinTimeRatio(cfgArgs.getMinTimeRatio()); | ||
| VMConfig.setDebug(cfgArgs.isDebug()); | ||
| VMConfig.setCheckFrozenTime(cfgArgs.getCheckFrozenTime()); | ||
| VMConfig.setProposalExpireTime(cfgArgs.getProposalExpireTime()); |
There was a problem hiding this comment.
Whether ProposalExpireTime should be in this VMConfig or not?
…nto hotfix/splitDBConfig
DorianRust
force-pushed
the
hotfix/splitDBConfig
branch
2 times, most recently
from
3abcc4a to
648a73e
Compare
DorianRust
force-pushed
the
hotfix/splitDBConfig
branch
from
648a73e to
e284a61
Compare
…nto hotfix/splitDBConfig
shydesky
approved these changes
Nov 27, 2019
DorianRust
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Split DB config to vmConfig
Why are these changes required?
Split DB config to vmConfig