Skip to content

fix(net): optimize activeNodes node adding logic #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

317787106
Copy link
Contributor

@317787106 317787106 commented Feb 15, 2023

What does this PR do?
Add fastForwardNode to activeNodes only if it is not exist.

Why are these changes required?
Fix the bug of activeNodes' size continuously growing problem.

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@317787106 317787106 changed the title fix(net): add fastForwardNode to activeNodes only if not exist fix(net): optimize activeNodes node adding logic Feb 15, 2023
@317787106 317787106 requested a review from xxo1shine February 15, 2023 06:09
@codecov-commenter
Copy link

Codecov Report

Merging #4994 (9e086c7) into release_v4.7.1 (b169228) will increase coverage by 0.14%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##             release_v4.7.1    #4994      +/-   ##
====================================================
+ Coverage             54.59%   54.74%   +0.14%     
- Complexity             8201     8225      +24     
====================================================
  Files                   840      840              
  Lines                 49642    49644       +2     
  Branches               5447     5448       +1     
====================================================
+ Hits                  27102    27176      +74     
+ Misses                20394    20329      -65     
+ Partials               2146     2139       -7     
Impacted Files Coverage Δ
.../org/tron/core/net/service/relay/RelayService.java 21.81% <0.00%> (-0.41%) ⬇️
...rc/main/java/org/tron/core/vm/program/Program.java 67.37% <0.00%> (+0.08%) ⬆️
...ain/java/org/tron/core/services/RpcApiService.java 4.95% <0.00%> (+0.12%) ⬆️
...ork/src/main/java/org/tron/core/trie/TrieImpl.java 58.24% <0.00%> (+0.35%) ⬆️
...mework/src/main/java/org/tron/core/db/Manager.java 53.07% <0.00%> (+0.37%) ⬆️
.../src/main/java/org/tron/core/ChainBaseManager.java 90.62% <0.00%> (+1.25%) ⬆️
...in/java/org/tron/common/zksnark/JLibrustzcash.java 53.84% <0.00%> (+1.39%) ⬆️
.../src/main/java/org/tron/core/config/args/Args.java 59.92% <0.00%> (+1.76%) ⬆️
...ain/java/org/tron/core/db/backup/BackupDbUtil.java 85.10% <0.00%> (+2.12%) ⬆️
...ain/java/org/tron/consensus/dpos/StateManager.java 51.02% <0.00%> (+4.08%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@317787106 317787106 merged commit 2a7f5aa into tronprotocol:release_v4.7.1 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants