feat(net):supplement disconnect reasons #5392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -601,6 +601,7 @@ enum ReasonCode { | |||
| TOO_MANY_PEERS_WITH_SAME_IP = 0x22; | |||
| LIGHT_NODE_SYNC_FAIL = 0x23; | |||
| BELOW_THAN_ME = 0X24; | |||
| NOT_WITNESS = 0x25; | |||
There was a problem hiding this comment.
Is it compatible with older versions?
There was a problem hiding this comment.
All of the newly added unrecognized ReasonCode will be converted to ReasonCode UNKNOWN, and no exception will be thrown.
There was a problem hiding this comment.
- It is recommended to make it more perfect, whether each of these merged cases defines a reason, and there are some unknown scenarios
case NO_SUCH_MESSAGE:
case MESSAGE_WITH_WRONG_LENGTH:
case BAD_MESSAGE:
code = Protocol.ReasonCode.BAD_PROTOCOL;
There was a problem hiding this comment.
@wubin01 there is no MESSAGE_WITH_WRONG_LENGTH really. But there is NO_SUCH_MESSAGE. Do you means add NO_SUCH_MESSAGE in Protocol.ReasonCode?
There was a problem hiding this comment.
I have added new ReasonCode NO_SUCH_MESSAGE in proto.
jwrct
approved these changes
Aug 21, 2023
xxo1shine
approved these changes
Sep 5, 2023
Nidacoke
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details