feat(service): exit when params init failed #6233
Merged
+112
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halibobo1205
force-pushed
the
feat/services_init_opt
branch
from
da88522 to
3d1eb7b
Compare
1. The node is witness, but no private key is configured 2. The configured rate limiter is not working as expected. 3. Configured auto-stop block time parsing error
halibobo1205
force-pushed
the
feat/services_init_opt
branch
from
3d1eb7b to
c9b7fbc
Compare
xxo1shine
approved these changes
Mar 11, 2025
yuekun0707
approved these changes
Mar 12, 2025
CodeNinjaEvan
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exit when params init failed:
witness, but noprivate keyis configuredrate limiteris not working as expected.auto-stop block timeparsing errorWhy are these changes required?
To ensure a healthy node startup, exit in time when the user input parameters are not as expected.
This PR has been tested by:
Follow up
Extra details