Skip to content

Invalid $value type in set commands #31

Open
@Hint-ru

Description

@Hint-ru

All set commands require strings for $value argument, but in fact we can pass mixed (arrays etc), because of serializers.
https://github.com/ukko/phpredis-phpdoc/blob/master/src/Redis.php#L222

    /**
     * Set the string value in argument as value of the key.
     *
     * @param   string  $key
     * @param   string  $value
     * @param   int   $timeout [optional] Calling setex() is preferred if you want a timeout.
     * @return  bool    TRUE if the command is successful.
     * @link    http://redis.io/commands/set
     * @example $redis->set('key', 'value');
     */
    public function set( $key, $value, $timeout = 0 ) {}

"string $value" should be replaced with "mixed $value". For now I get false-positive "expected string" in inspections.

Proof: phpredis/phpredis#450 (comment)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions