Skip to content

Conversation

@luc122c
Copy link
Contributor

@luc122c luc122c commented Oct 25, 2023

πŸ”— Linked issue

Related to #58 and nuxt/nuxt#23696

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Inspired by the type testing in the main nuxt repo, I've moved the type tests out to their own file, and converted them to vitest syntax. This means the // eslint-disable-next-line @typescript-eslint/no-unused-vars comments are no longer requred. It also makes the tests more consistent.

I would imagine there may be conficts with the changes in #58, which I can resolve when that one is merged.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (21f19ba) 100.00% compared to head (64fa9c4) 100.00%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #61    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1         2     +1     
  Lines          131       272   +141     
  Branches        35        34     -1     
==========================================
+ Hits           131       272   +141     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 merged commit 8bdcf51 into unjs:main Nov 15, 2023
@pi0
Copy link
Member

pi0 commented Nov 15, 2023

Thanks!

@luc122c luc122c deleted the type-tests branch November 15, 2023 17:07
@luc122c
Copy link
Contributor Author

luc122c commented Nov 15, 2023

Thanks!

No problem! Please could you publish a new release when possible so that I can integrate the changes into nuxt/nuxt#23696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants