fix: Resolve evaluation issues in SUM() and CONVERT_TZ() functions #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasom
force-pushed
the
fix_evaluation
branch
from
79dff92 to
4dccefa
Compare
aaronm67
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two evaluation issues in SQL functions:
SUM() Evaluation: The change ensures that the
SUM()function can correctly evaluate expressions (e.g.,SUM(a + b)).CONVERT_TZ() Null Handling: A check has been added to the
CONVERT_TZ()function to handle cases where a column expression is empty (null). This prevents a fatal error and ensures the function behaves gracefully when processing incomplete or missing data.