Skip to content

Conversation

@zoul0813
Copy link
Member

fixes #333 - adds "labelClasses" to the field schema, allowing you to configure icons and other styles to labels via CSS classes.

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. But please add relevant unit tests too.

@zoul0813
Copy link
Member Author

Not too familiar with your testing policies ... does the formGenerator test cover it?

} // fieldset
</style>
// .errors
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops ... how'd that get there?

not sure how that got there
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@icebob icebob merged commit c68c6bb into vue-generators:master Nov 11, 2017
@zoul0813 zoul0813 deleted the feature/333-label-classes branch November 13, 2017 14:20
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this pull request Nov 15, 2017
@PushpinderRattan
Copy link

labelClasses field does not seem to be working for me as I am trying to add a fontawesome icon next to the field. Is there anyway to do so? Do you have any example?
Thank you.

@PushpinderRattan
Copy link

Please ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to add label icons?

3 participants