Skip to content

Fix grammar #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Fix grammar #2122

merged 2 commits into from
Jan 10, 2023

Conversation

de-oz
Copy link
Contributor

@de-oz de-oz commented Dec 8, 2022

Description of Problem

The sentence is structured in such a way that it is either missing a word or has words arranged incorrectly.

Current incorrect version:

v-model works not only on text inputs, but also [missing "on" here] other input types such as checkboxes, . . .

Correct version:

v-model works not only on text inputs, but also on other input types such as checkboxes,

Proposed Solution

The problem could be solved by adding the word "on" before "other input types" as shown above, but I chose to slightly rearrange the words of the sentence without any additions to get the same result and avoid repetition of the word "on".

@netlify
Copy link

netlify bot commented Dec 8, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 8232c82
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/63bd336ba3cc6a000a82dec8
😎 Deploy Preview https://deploy-preview-2122--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've added a comment regarding two on

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@de-oz thank you for applying the suggestion! PR looks good to me, approved 👍🏻

@NataliaTepluhina NataliaTepluhina merged commit 7b7b4a9 into vuejs:main Jan 10, 2023
@de-oz de-oz deleted the de-oz-patch branch January 10, 2023 11:35
Abdelaziz18003 referenced this pull request in vuejs-translations/docs-ar Jan 11, 2023
* Fix grammar

* Update src/tutorial/src/step-5/description.md

Co-authored-by: Natalia Tepluhina <[email protected]>

Co-authored-by: Natalia Tepluhina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants