Skip to content

Fix a typo in ElasticHeader.vue #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Fix a typo in ElasticHeader.vue #2277

merged 1 commit into from
Mar 9, 2023

Conversation

midiidev
Copy link

@midiidev midiidev commented Mar 8, 2023

firction -> friction

Description of Problem

friction was spelled as "firction" causing editing the property to have no effect.

Proposed Solution

Change the spelling to friction

Additional Information

Also changed the spelling in the playground example

firction -> friction
@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 3993c88
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6408e3c7bf86d8000822988d
😎 Deploy Preview https://deploy-preview-2277--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

While testing this I noticed that the example in the docs is broken. It doesn't spring back when released. It works fine in the Playground. That doesn't seem to be related to your change, though.

@skirtles-code skirtles-code merged commit bf04a7c into vuejs:main Mar 9, 2023
@midiidev
Copy link
Author

midiidev commented Mar 9, 2023

Thanks for the fix!

While testing this I noticed that the example in the docs is broken. It doesn't spring back when released. It works fine in the Playground. That doesn't seem to be related to your change, though.

before my fix, this was still happening. I honestly am not sure what that problem is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants