Fix animated ElasticHeader demo #2282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bencodezen
approved these changes
Mar 11, 2023
|
Fantastic investigation into this and fixing it @skirtles-code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ElasticHeader demo is supposed to ping back when the drag ends, but currently it just freezes in place.
This bug was introduced by a recent change to remove Reactivity Transforms, 1bc0434.
Specifically, the problem is on line 44/45, where the first argument passed to
dynamics.animateneeds to be a reactive object. The animation is driven by changing that object, so passing a throwaway wrapper object doesn't work.I reverted the code back to the Reactivity Transforms version and then changed
$reftoreactive.Fixed demo: https://deploy-preview-2282--vuejs.netlify.app/guide/extras/animation.html#state-driven-animations