Skip to content

Change Ukrainian translation as completed #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

matrunchyk
Copy link
Contributor

@matrunchyk matrunchyk commented Mar 15, 2023

I'm pleased to announce that the Ukrainian translation is now completed and we're switching to maintenance mode now! (And switching to other products of the Vue ecosystem).

Big thanks to our Ukrainian community, especially @vozniukvolodymyr, @maxdzin, @nazar1ua, @OlesyaKlochko, @dddarkasss, @winato, @MaksymOsovitnii.

Proud of you guys!

@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 8b9b9ad
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/64119607124bbf000769fdb3
😎 Deploy Preview https://deploy-preview-2289--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@matrunchyk
Copy link
Contributor Author

Tagging @skirtles-code as one of Collaborators. Thanks!

@matrunchyk
Copy link
Contributor Author

Also tagging @NataliaTepluhina :)

@skirtles-code
Copy link
Contributor

skirtles-code commented Mar 21, 2023

Great work on the translation!

I don't know Ukrainian, but I took a look through the translation anyway:

@matrunchyk
Copy link
Contributor Author

Great work on the translation!

I don't know Ukrainian, but I took a look through the translation anyway:

  • Some pages are still in English, e.g. those in the /about section.
  • The languages list in the main nav needs to include a link back to the English docs (see the Chinese or Japanese translations as a reference).
  • I found a few broken links:

Thanks for the review!

I went over all your comments and have made changes to the translation here and here.

@skirtles-code skirtles-code merged commit 1faadee into vuejs:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants