Skip to content

fix: add support for custom elements for CompileScript #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

fix: add support for custom elements for CompileScript #354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec8fb5
fix: add support for custom elements for CompileScript
Gianthard-cyh Jul 12, 2025
bed13e5
Merge branch 'main' into main
edison1105 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,22 @@ export async function compileFile(
ssrCode += code
}

const ceFilter = store.sfcOptions.script?.customElement || /\.ce\.vue$/
function isCustomElement(filters: typeof ceFilter): boolean {
if (typeof filters === 'boolean') {
return filters
}
if (typeof filters === 'function') {
return filters(filename)
}
return filters.test(filename)
}
let isCE = isCustomElement(ceFilter)

let clientScript: string
let bindings: BindingMetadata | undefined
try {
const res = await doCompileScript(store, descriptor, id, false, isTS, isJSX)
const res = await doCompileScript(store, descriptor, id, false, isTS, isJSX, isCE)
clientScript = res.code
bindings = res.bindings
clientScriptMap = res.map
Expand All @@ -147,6 +159,7 @@ export async function compileFile(
true,
isTS,
isJSX,
isCE
)
ssrScript = ssrScriptResult.code
ssrCode += ssrScript
Expand Down Expand Up @@ -212,18 +225,6 @@ export async function compileFile(
}

// styles
const ceFilter = store.sfcOptions.script?.customElement || /\.ce\.vue$/
function isCustomElement(filters: typeof ceFilter): boolean {
if (typeof filters === 'boolean') {
return filters
}
if (typeof filters === 'function') {
return filters(filename)
}
return filters.test(filename)
}
let isCE = isCustomElement(ceFilter)

let css = ''
let styles: string[] = []
for (const style of descriptor.styles) {
Expand Down Expand Up @@ -295,6 +296,7 @@ async function doCompileScript(
ssr: boolean,
isTS: boolean,
isJSX: boolean,
isCustomElement: boolean,
): Promise<{ code: string; bindings: BindingMetadata | undefined; map?: any }> {
if (descriptor.script || descriptor.scriptSetup) {
const expressionPlugins: CompilerOptions['expressionPlugins'] = []
Expand All @@ -318,6 +320,7 @@ async function doCompileScript(
expressionPlugins,
},
},
customElement: isCustomElement,
})
let code = compiledScript.content
if (isTS) {
Expand Down