Skip to content

Minor improvements for 2.x warning #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2016
Merged

Minor improvements for 2.x warning #259

merged 1 commit into from
Dec 7, 2016

Conversation

phanan
Copy link
Member

@phanan phanan commented Dec 7, 2016

There are two problems (IMHO at least) with the current 2.x "warning":

  • It's not an error per se, more like an information, so I changed the color to green instead of red.
  • Grammar.

Since both happen in one line, I decided to merge them into one commit.

posva
posva approved these changes Dec 7, 2016
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it feels weird to have the red message now that 2 is being so largely adopted

@zigomir
Copy link
Contributor

zigomir commented Dec 7, 2016

I agree as well. I'm merging because we're already 3 :)

@zigomir zigomir merged commit 365ffe8 into vuejs:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phanan @zigomir @posva