Skip to content

Small code fix for hot-reload #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Small code fix for hot-reload #1079

merged 1 commit into from
Dec 15, 2017

Conversation

Jinjiang
Copy link
Member

Removed the unnecessary string concatenation, though it's no error caused.

Generated code before this fix:

/* hot reload */
if (module.hot) {(function () {
  var hotAPI = require("vue-loader/node_modules/vue-hot-reload-api")
  hotAPI.install(require("vue"), false)
  if (!hotAPI.compatible) return
  module.hot.accept()
  if (!module.hot.data) {
    hotAPI.createRecord("data-v-7ba5bd90", Component.options)
  } else {
    hotAPI.reload("data-v-7ba5bd90", Component.options)
' + '  }
  module.hot.dispose(function (data) {
    disposed = true
  })
})()}

Thanks.

@yyx990803 yyx990803 merged commit ecea3c3 into vuejs:master Dec 15, 2017
@Jinjiang Jinjiang deleted the small-fix branch December 15, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants