Skip to content

Check existence of module parent in isRegistered (fix #1850) #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2020
Merged

Check existence of module parent in isRegistered (fix #1850) #1851

merged 2 commits into from
Nov 5, 2020

Conversation

urbnjamesmi1
Copy link

This PR fixes issue #1850 .

If you call store.hasModule() with an array where none of the modules or submodules are registered in the store, an error is thrown instead of returning false:

TypeError: Cannot read property 'hasChild' of undefined
        at ModuleCollection.isRegistered (/node_modules/vuex/dist/vuex.common.js:291:17)
        at Store.hasModule (/node_modules/vuex/dist/vuex.common.js:611:24)

@urbnjamesmi1 urbnjamesmi1 force-pushed the bug/hasModule-undefined-parent branch from dd5f21d to 93967bc Compare October 16, 2020 22:13
kiaking
kiaking approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looking nice 👍

@kiaking kiaking merged commit 12aabe4 into vuejs:dev Nov 5, 2020
@urbnjamesmi1 urbnjamesmi1 deleted the bug/hasModule-undefined-parent branch November 5, 2020 14:22
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 2, 2024
Open
@wjygit0428 wjygit0428 mentioned this pull request Aug 10, 2024
Open
This was referenced Aug 20, 2024
Open
Open
@angeloreale angeloreale mentioned this pull request Aug 27, 2024
Open
@natbia natbia mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiaking kiaking kiaking approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@urbnjamesmi1 @kiaking