Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/module/module-collection.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ export default class ModuleCollection {
const parent = this.get(path.slice(0, -1))
const key = path[path.length - 1]

return parent.hasChild(key)
if (parent) {
return parent.hasChild(key)
}

return false
}
}

Expand Down
17 changes: 17 additions & 0 deletions test/unit/module/module-collection.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,23 @@ describe('ModuleCollection', () => {
expect(collection.get(['a'])).toBe(undefined)
})

it('isRegistered', () => {
const collection = new ModuleCollection({})

collection.register(['a'], {
state: { value: true }
})

collection.register(['a', 'b'], {
state: { value: false }
})

expect(collection.isRegistered(['a'])).toBe(true)
expect(collection.isRegistered(['a', 'b'])).toBe(true)
expect(collection.isRegistered(['c'])).toBe(false)
expect(collection.isRegistered(['c', 'd'])).toBe(false)
})

it('does not unregister initial modules', () => {
const collection = new ModuleCollection({
modules: {
Expand Down
12 changes: 12 additions & 0 deletions test/unit/modules.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,18 @@ describe('Modules', () => {
expect(store.hasModule('bonjour')).toBe(false)
})

it('dynamic module existance test with nested modules', () => {
const store = new Vuex.Store({})

store.registerModule('a', {})
store.registerModule(['a', 'b'], {})

expect(store.hasModule(['a'])).toBe(true)
expect(store.hasModule(['a', 'b'])).toBe(true)
expect(store.hasModule(['c'])).toBe(false)
expect(store.hasModule(['c', 'd'])).toBe(false)
})

it('dynamic module registration preserving hydration', () => {
const store = new Vuex.Store({})
store.replaceState({ a: { foo: 'state' }})
Expand Down